-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent NM from automatic (DHCP) configuration on ethernet devices #840
Open
vcandapp
wants to merge
1
commit into
openstack-k8s-operators:main
Choose a base branch
from
vcandapp:jira_OSPRH_9142
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcandapp
force-pushed
the
jira_OSPRH_9142
branch
from
December 6, 2024 12:25
06a8541
to
bc29060
Compare
vcandapp
changed the title
Prevent NM from automatic (DHCP/SLAAC) configuration on ethernet devices
Prevent NM from automatic (DHCP) configuration on ethernet devices
Dec 6, 2024
vcandapp
force-pushed
the
jira_OSPRH_9142
branch
2 times, most recently
from
December 9, 2024 09:52
fbda264
to
c38781c
Compare
recheck |
vcandapp
force-pushed
the
jira_OSPRH_9142
branch
from
December 10, 2024 12:07
c38781c
to
c38f438
Compare
When edpm_network_config role uses os-net-config to perform host network configuration, duplicate DHCP requests from NM are causing issue. Eg. https://issues.redhat.com/browse/OSPRH-9142 This fix prevents NM to configure DHCP by default
vcandapp
force-pushed
the
jira_OSPRH_9142
branch
from
December 12, 2024 11:26
c38f438
to
2ae86e1
Compare
slagle
approved these changes
Dec 18, 2024
bshephar
approved these changes
Dec 23, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, slagle, vcandapp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
recheck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When edpm_network_config role uses os-net-config to perform host network configuration, duplicate DHCP requests from NM are causing connectivity issue. Eg.
https://issues.redhat.com/browse/OSPRH-9142
This fix prevents NM from configure DHCP by default
This PR replaces an older PR